Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated so it shows the correct versions of Python #1515

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Updated so it shows the correct versions of Python #1515

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326e532
Updated so it shows the correct versions of Python
DangerChamp Jan 8, 2022
0eac1a5
Deleted pdftotext section
DangerChamp Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,21 @@ the test for vendor_package_pairs:

## Running tests on different versions of Python

Our CI currently runs tests on Python 3.6 and 3.7 under Linux.
Our CI currently runs tests on Python 3.7 - 3.10 under Linux.

The recommended way to do this yourself is to use python's `virtualenv`

You can set up virtualenv for all these environments:

```console
virtualenv -p python3.6 venv3.6
virtualenv -p python3.7 venv3.7
virtualenv -p python3.8 venv3.8
virtualenv -p python3.9 venv3.9
```

To activate one of these (the example uses 3.6), run the tests, and deactivate:
To activate one of these (the example uses 3.8), run the tests, and deactivate:

```console
source venv3.6/bin/activate
source venv3.8/bin/activate
python setup.py test
deactivate

Expand Down Expand Up @@ -146,4 +146,4 @@ pytest -v test/test_checkers.py -k python

## Known issues

If you're using Windows we **strongly** recommend also `pdftotext`. We experienced problems running tests without this. The best approach to do this is through [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html) (click [here](https://anaconda.org/conda-forge/pdftotext) to find out how to install this package with conda).
If you're using Windows we **strongly** recommend also `pdftotext`. We experienced problems running tests without this. The best approach to do this is through [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html) (click [here](https://anaconda.org/conda-forge/pdftotext) to find out how to install this package with conda).
Copy link
Contributor

@BreadGenie BreadGenie Jan 9, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terriko isn't it suggested that we install pdftotext irrelevant of the OS, but recommended to install it via conda for windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @anthonyharrison 's changes have made it so that it will fail gracefully if pdftotext is not installed regardless of platform, so we don't need this message any more. It's out of scope for this pull request anyhow and I'm not sure why it's showing up. Reversion from an earlier version maybe?