CONTRIBUTING.md , README.md , doc/RELEASE.md habe been modified #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkrm1612 Thank you for your first pull request - I hope it is the first of many. We follow the conventional commits standard for commit messages and normally reference the issue which is being fixed. Can you update your pull requests with the category of the change. For example, I think this pull request should read doc: minor updates to CONTRIBUTING.md , README.md , doc/RELEASE.md (Fix #1527) |
|
Looks like this was already fixed in #1532, so I'm going to go ahead and close this one. Thank you, though, it looks like you had the right solution you just weren't the first to submit it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first Pull Request......!
Thank You