Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Javascript package scanning (Fixes #1453) #1548

Merged
merged 57 commits into from Feb 16, 2022

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

anthonyharrison and others added 30 commits May 27, 2020 12:55
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good. I tried to upgrade the type hints, you'll probably want to double-check that I put them in correctly before accepting the suggestions. (see note below on the one I'm not sure about)

Other than improving the type hints, I think this is ready to merge.

cve_bin_tool/version_scanner.py Outdated Show resolved Hide resolved
cve_bin_tool/version_scanner.py Outdated Show resolved Hide resolved
cve_bin_tool/version_scanner.py Outdated Show resolved Hide resolved
test/test_language_scanner.py Outdated Show resolved Hide resolved
test/test_language_scanner.py Outdated Show resolved Hide resolved
test/test_language_scanner.py Outdated Show resolved Hide resolved
test/test_language_scanner.py Outdated Show resolved Hide resolved
anthonyharrison and others added 7 commits February 9, 2022 21:37
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
@anthonyharrison
Copy link
Contributor Author

@terriko Happy with the suggestions. version_scanner.py needs type hints to be added to the rest of the functions but that can be picked up as part of the general tidy up of adding type hints across all of the modules.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #1548 (ccf8ebe) into main (62ae407) will increase coverage by 0.59%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
+ Coverage   80.36%   80.95%   +0.59%     
==========================================
  Files         281      282       +1     
  Lines        5581     5677      +96     
  Branches      913      938      +25     
==========================================
+ Hits         4485     4596     +111     
+ Misses        897      865      -32     
- Partials      199      216      +17     
Flag Coverage Δ
longtests 80.95% <82.85%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cli.py 70.79% <33.33%> (-0.64%) ⬇️
test/test_checkers.py 93.54% <66.66%> (-3.07%) ⬇️
cve_bin_tool/version_scanner.py 76.00% <81.13%> (+19.56%) ⬆️
test/test_language_scanner.py 90.69% <90.69%> (ø)
cve_bin_tool/nvd_api.py 81.00% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d95852...ccf8ebe. Read the comment docs.

@terriko
Copy link
Contributor

terriko commented Feb 16, 2022

Looking good. Sorry it's taken me so long to get back to this to get it merged!

@terriko terriko merged commit 19ebb0d into intel:main Feb 16, 2022
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants