New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added libseccomp checker #1556
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 80.25% 82.39% +2.14%
==========================================
Files 281 283 +2
Lines 5581 5590 +9
Branches 911 912 +1
==========================================
+ Hits 4479 4606 +127
+ Misses 904 791 -113
+ Partials 198 193 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@BreadGenie please review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me!
We follow conventional commits so you need to change the PR title and in the future commit messages also to follow conventional commits
I've fixed the commit message and the PR title. |
f7edeea
to
5121ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
fixes #1493
The signatures are not ideal but I tried to test the used pattern for several packages (.apk, .deb, .rpm) and it seems to work fine.