Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added libseccomp checker #1556

Merged
merged 1 commit into from Feb 22, 2022
Merged

feat: added libseccomp checker #1556

merged 1 commit into from Feb 22, 2022

Conversation

yashugarg
Copy link
Contributor

@yashugarg yashugarg commented Jan 27, 2022

fixes #1493
The signatures are not ideal but I tried to test the used pattern for several packages (.apk, .deb, .rpm) and it seems to work fine.

@codecov-commenter
Copy link

Codecov Report

Merging #1556 (c100651) into main (d6ade7c) will increase coverage by 2.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
+ Coverage   80.25%   82.39%   +2.14%     
==========================================
  Files         281      283       +2     
  Lines        5581     5590       +9     
  Branches      911      912       +1     
==========================================
+ Hits         4479     4606     +127     
+ Misses        904      791     -113     
+ Partials      198      193       -5     
Flag Coverage Δ
longtests 82.39% <100.00%> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/libseccomp.py 100.00% <100.00%> (ø)
test/test_data/libseccomp.py 100.00% <100.00%> (ø)
cve_bin_tool/version_scanner.py 57.42% <0.00%> (+0.99%) ⬆️
cve_bin_tool/extractor.py 65.21% <0.00%> (+1.24%) ⬆️
cve_bin_tool/cli.py 73.66% <0.00%> (+2.23%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+4.16%) ⬆️
test/test_cli.py 93.60% <0.00%> (+10.95%) ⬆️
test/test_scanner.py 74.61% <0.00%> (+12.30%) ⬆️
cve_bin_tool/cvedb.py 85.83% <0.00%> (+13.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ade7c...c100651. Read the comment docs.

@yashugarg
Copy link
Contributor Author

@BreadGenie please review the PR

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!
We follow conventional commits so you need to change the PR title and in the future commit messages also to follow conventional commits

@yashugarg yashugarg changed the title New checker: libseccomp feat: added libseccomp checker Jan 31, 2022
@yashugarg
Copy link
Contributor Author

I've fixed the commit message and the PR title.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terriko terriko merged commit b436343 into intel:main Feb 22, 2022
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
@yashugarg yashugarg deleted the libseccomp branch July 5, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Checker Request: Libseccomp
4 participants