-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pre-commit): add conventional commit hook #1564
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
- Coverage 80.34% 80.27% -0.08%
==========================================
Files 281 281
Lines 5581 5581
Branches 911 911
==========================================
- Hits 4484 4480 -4
- Misses 899 902 +3
- Partials 198 199 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Seems like we won't be able to enable it in our CI. Refer compilerla/conventional-pre-commit#9 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this really solves the problem for us comprehensively enough, but it might improve the quality of messages from new contributors, so it's worth a shot as a partial solution.
I found a better replacement in gitlint. I'll create another PR after I ensure about running it in CI. I'll be marking this as draft for now. |
Closing in favor of #1573 |
fix #1563