Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): add conventional commit hook #1564

Closed
wants to merge 7 commits into from

Conversation

BreadGenie
Copy link
Contributor

fix #1563

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #1564 (770fc6d) into main (7dd0d75) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   80.34%   80.27%   -0.08%     
==========================================
  Files         281      281              
  Lines        5581     5581              
  Branches      911      911              
==========================================
- Hits         4484     4480       -4     
- Misses        899      902       +3     
- Partials      198      199       +1     
Flag Coverage Δ
longtests 80.27% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/nvd_api.py 81.00% <0.00%> (-5.00%) ⬇️
cve_bin_tool/cvedb.py 72.22% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd0d75...770fc6d. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@BreadGenie
Copy link
Contributor Author

Seems like we won't be able to enable it in our CI. Refer compilerla/conventional-pre-commit#9 (comment)

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this really solves the problem for us comprehensively enough, but it might improve the quality of messages from new contributors, so it's worth a shot as a partial solution.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@BreadGenie BreadGenie changed the title ci(pre-commit): add conventional commit pre-hook ci(pre-commit): add conventional commit pre-commit hook Feb 3, 2022
@BreadGenie BreadGenie changed the title ci(pre-commit): add conventional commit pre-commit hook ci(pre-commit): add conventional commit hook Feb 3, 2022
@BreadGenie
Copy link
Contributor Author

BreadGenie commented Feb 8, 2022

I found a better replacement in gitlint. I'll create another PR after I ensure about running it in CI. I'll be marking this as draft for now.

@BreadGenie BreadGenie marked this pull request as draft February 8, 2022 17:05
@BreadGenie
Copy link
Contributor Author

Closing in favor of #1573

@BreadGenie BreadGenie closed this Feb 9, 2022
@BreadGenie BreadGenie deleted the conv-commt-hook branch February 9, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Enforce conventional commit message format in commits
4 participants