refactor: add type hints in strings.py and file.py #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhythmrx9
changed the title
terriko
requested changes
Feb 2, 2022
There was a problem hiding this comment.
This looks like a good start, but I'd like to see type hints on every argument if possible. rather than just setting up the return type hint. e.g. is filename a str on line 14?
(I know, we haven't done this consistently elsewhere, but we're aiming for consistency that we'll be able to enforce, and this isn't quite there yet!)
Molkree
reviewed
Feb 5, 2022
|
I think this is looking pretty good. I'm approving the CI to double-check the function on all platforms before I do a review. (CI keeps waiting on approval because you're a new contributor.) |
|
Updating branch and re-running CI before merge. |
terriko
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1539