New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate from urllib to requests #1569
Conversation
BreadGenie
commented
Feb 5, 2022
- fix Refactor: requests library vs urlib* #1311
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
+ Coverage 80.34% 83.11% +2.77%
==========================================
Files 281 281
Lines 5581 5574 -7
Branches 911 913 +2
==========================================
+ Hits 4484 4633 +149
+ Misses 899 750 -149
+ Partials 198 191 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f130067
to
5971920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. I think you're right about .ConnectionError not being the right one, but if we address that this should be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for doing this! I see CI got rate limited in the long tests but otherwise looks fine.