-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add type hints in util.py #1572
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dd5cb04
refactor: type hints in util.py
rhythmrx9 0f4908b
ci: updating the pull request with changes in main
rhythmrx9 521724e
refactor: arguments to new __new__
rhythmrx9 f5dac76
refactor: CVEData
rhythmrx9 51cb63e
refactor: simplifying type hints
rhythmrx9 24b960a
refactor: type hints in regex_find
rhythmrx9 316cd8b
refactor: imports in util.py
rhythmrx9 583202b
refactor: simplifying type hints
rhythmrx9 fefb212
refactor: simplifying type hints
rhythmrx9 048ccc2
refactor: improving type hints in util.py
rhythmrx9 6d60d01
fix: inline type hints
rhythmrx9 ff1a8a7
fix: imports for inline type hints
rhythmrx9 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one have a return type? I'm not sure if those are needed for __ functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do already use type hints for __ functions, I think we should have them, to be consistent.