feat: retry if NVD API Key is invalid

[terriko]

This is a draft that shouldn't be working yet, but comments, review and suggestions are very welcome because I'm currently blocked on what to do next.

I'm still trying to figure out the best way to handle unsetting the NVD API Key if it proves to be invalid.

This version just has it retry, but I'm not convinced the parameter setting works as expected (I think we need to change it in the request) and the second attempt is slow.

[imsahil007]

terriko#3

[terriko]

Merged @imsahil007 's suggested PR. (thought I did this before I was out for a US long weekend, but apparently not!) I think that's the right direction to go. We may still have issues with the actual CI.

[terriko]

There was a syntax error in the apiKey check, and I've updated the pull request to the latest tree. the nvd tests pass for me locally, so that's a good sign?

[terriko]

re-wrote commit messages so gitlint would quit complaining.

[terriko]

@imsahil007 @BreadGenie @anthonyharrison
This is ready for review. The good news is that the code seems to work. The bad news is that the CI pass-through of the key does not, so it's not actually using the key, and the nvd long test that's occasionally a problem is still failing.

From my reading of the docs, this may be expected behaviour and the key secret will pass only when this runs on main. Once this passes code review, I'd like to merge it and we'll work on improved key passthrough in a separate pull request.

[anthonyharrison]

Looks OK to me

[terriko]

Okay, I'm going to go ahead and merge this since @anthonyharrison 's had a chance to review it and found no concerns. Further refinement after merging is always welcome!