Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/bread genie/1573 #1578

Closed
wants to merge 5 commits into from
Closed

Pr/bread genie/1573 #1578

wants to merge 5 commits into from

Conversation

Molkree
Copy link
Contributor

@Molkree Molkree commented Feb 10, 2022

Testing gitlint

@BreadGenie
Copy link
Contributor

BreadGenie commented Feb 10, 2022

Phew. I did try it with range of commits at first but it didn't work, maybe because I didn't change ref from merge commit to the head of PR It was the fetch-depth. Thanks for getting it working (spent quite a time on it).

@Molkree
Copy link
Contributor Author

Molkree commented Feb 10, 2022

Closing in favour of original PR where the credit is due, this one was just to test the commit range fix.

@Molkree Molkree closed this Feb 10, 2022
@Molkree Molkree deleted the pr/BreadGenie/1573 branch February 10, 2022 17:49
@Molkree
Copy link
Contributor Author

Molkree commented Feb 10, 2022

Thanks for getting it working

@BreadGenie, yeah, I hope it covers everything, it's still pretty complicated stuff for me...

@BreadGenie
Copy link
Contributor

Never thought I'd be fumbling around this long. It was harder than I thought. Especially since we can't properly test it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants