Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asyncio warnings (#1558) #1592

Merged
merged 1 commit into from Mar 8, 2022
Merged

fix: asyncio warnings (#1558) #1592

merged 1 commit into from Mar 8, 2022

Conversation

XDRAGON2002
Copy link
Contributor

Fixes #1558

@codecov-commenter
Copy link

Codecov Report

Merging #1592 (828119e) into main (e36bc96) will decrease coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   82.40%   81.17%   -1.24%     
==========================================
  Files         279      290      +11     
  Lines        5450     5710     +260     
  Branches      885      942      +57     
==========================================
+ Hits         4491     4635     +144     
- Misses        769      859      +90     
- Partials      190      216      +26     
Flag Coverage Δ
longtests 81.17% <ø> (-1.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_cvedb.py 58.53% <0.00%> (-41.47%) ⬇️
test/test_available_fix.py 76.47% <0.00%> (-23.53%) ⬇️
cve_bin_tool/cvedb.py 72.22% <0.00%> (-10.19%) ⬇️
cve_bin_tool/available_fix/redhat_cve_tracker.py 71.42% <0.00%> (-9.61%) ⬇️
cve_bin_tool/available_fix/debian_cve_tracker.py 77.55% <0.00%> (-5.79%) ⬇️
cve_bin_tool/cli.py 70.79% <0.00%> (-3.83%) ⬇️
cve_bin_tool/version.py 64.70% <0.00%> (-3.72%) ⬇️
test/test_checkers.py 93.54% <0.00%> (-3.07%) ⬇️
cve_bin_tool/util.py 75.00% <0.00%> (-0.48%) ⬇️
test/utils.py 93.54% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36bc96...828119e. Read the comment docs.

@XDRAGON2002
Copy link
Contributor Author

I have added the pytest asyncio config in the setup.cfg file, I was also taking a look at and working on #1584 and the config file for pyright is recommended to be pyproject.toml (even pytest suggests its better to use pyproject.toml instead of setup.cfg here).

So as we are going to be integrating pyright soon as well, would it be better to move these configs to pyproject.toml right now? Or is it fine to have multiple config files (even though we can merge them together)? Or even merge them in one after pyright is enforced?

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear that setuptools (which is why we have setup.cfg) is getting end of lifed soon, which is why people don't recommend it any more. Our config file is vintage to the age when we supported python 2.7.

I haven't dug through the recommended best procedure yet but I expect we'll be migrating to pyproject.toml sometime soon. Pyright might be a good excuse to make the switch now, since I definitely don't want multiple config files.

That said, adding this to the existing config file to fix something right now sounds totally fine. I'll go ahead and merge it and I'll open a bug for replacing setup.cfg if we don't have one already.

@terriko terriko merged commit 88dcc1a into intel:main Mar 8, 2022
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DeprecationWarnings by switching asyncio_mode
3 participants