Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch format_checker to run in ci #1593

Merged
merged 6 commits into from Mar 8, 2022
Merged

Conversation

rhythmrx9
Copy link
Contributor

closes #1582
format_checker no longer runs as a linting check and in pre-commit.
A pull request is created with updated checkers table when a new checker is merged.

@codecov-commenter
Copy link

Codecov Report

Merging #1593 (cb4cdec) into main (184b4e8) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   80.98%   81.17%   +0.18%     
==========================================
  Files         284      290       +6     
  Lines        5681     5710      +29     
  Branches      939      942       +3     
==========================================
+ Hits         4601     4635      +34     
+ Misses        864      859       -5     
  Partials      216      216              
Flag Coverage Δ
longtests 81.17% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/libebml.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/libseccomp.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/libsolv.py 100.00% <100.00%> (ø)
test/test_data/libebml.py 100.00% <100.00%> (ø)
test/test_data/libseccomp.py 100.00% <100.00%> (ø)
test/test_data/libsolv.py 100.00% <100.00%> (ø)
test/test_input_engine.py 100.00% <100.00%> (ø)
test/test_merge.py 100.00% <100.00%> (ø)
test/test_scanner.py 62.30% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70973dd...cb4cdec. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully this will make the process a bit easier going forwards.

@terriko terriko merged commit 7a9827e into intel:main Mar 8, 2022
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
* closes intel#1582

* ci: remove format_checkers from pre-commit

* ci: removing format_checkers from linting

* ci: run format_checkers if checkers are added

* fix: formatting

* fix: commit branch

* docs: updating checker table
@rhythmrx9 rhythmrx9 deleted the format_checker branch March 10, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch format_checker to run in CI on an interval instead of as a linting check
3 participants