Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run gitlint on PR title #1597

Merged
merged 2 commits into from Mar 14, 2022
Merged

ci: run gitlint on PR title #1597

merged 2 commits into from Mar 14, 2022

Conversation

rhythmrx9
Copy link
Contributor

closes #1596

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #1597 (2e5bfae) into main (9c73442) will decrease coverage by 1.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   83.59%   81.66%   -1.93%     
==========================================
  Files         290      290              
  Lines        5771     5771              
  Branches      949      949              
==========================================
- Hits         4824     4713     -111     
- Misses        730      837     +107     
- Partials      217      221       +4     
Flag Coverage Δ
longtests 81.66% <ø> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 70.00% <0.00%> (-20.00%) ⬇️
cve_bin_tool/cvedb.py 72.22% <0.00%> (-13.89%) ⬇️
test/test_scanner.py 62.30% <0.00%> (-12.31%) ⬇️
test/test_cli.py 82.64% <0.00%> (-10.96%) ⬇️
cve_bin_tool/checkers/glibc.py 95.83% <0.00%> (-4.17%) ⬇️
cve_bin_tool/cli.py 70.79% <0.00%> (-2.22%) ⬇️
cve_bin_tool/extractor.py 63.97% <0.00%> (-1.25%) ⬇️
cve_bin_tool/version_scanner.py 76.30% <0.00%> (-0.81%) ⬇️
cve_bin_tool/available_fix/debian_cve_tracker.py 77.55% <0.00%> (+14.28%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove line 18 & 19 safely now that we aren't bothered about commits.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; let's try it out!

@terriko terriko merged commit a4e8de7 into intel:main Mar 14, 2022
@rhythmrx9 rhythmrx9 deleted the gitlint branch March 21, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "gitlint" with a pull request title linter
4 participants