Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo and formatting fixes #1619

Merged
merged 2 commits into from Mar 29, 2022
Merged

doc: typo and formatting fixes #1619

merged 2 commits into from Mar 29, 2022

Conversation

Alienmaster
Copy link
Contributor

Small typos and changes for readability.

Small typos and changes for readability.
Fix link to Github CI
@Alienmaster Alienmaster changed the title Update CONTRIBUTING.md Update docs Mar 29, 2022
@terriko
Copy link
Contributor

terriko commented Mar 29, 2022

Approved this to re-run but it's going to fail the conventional commits linter. You can read more about conventional commits here: https://www.conventionalcommits.org/en/v1.0.0/

But probably a good message here would be "doc: typo and formatting fixes" -- if you set that as your pull request title, it'll resolve the linting error going forwards.

@Alienmaster Alienmaster changed the title Update docs doc: typo and formatting fixes Mar 29, 2022
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You've got a fix for the doctest issue in another PR and I've got one for black in one as well, so none of the failing tests in CI need to be addressed by this PR. I'm going to go ahead and merge it while we wait for the others to resolve (this should also make it so your workflows run automatically on the other PR going forwards, so it'll make it easier to work on that one!)

@terriko terriko merged commit 90d27db into intel:main Mar 29, 2022
@Alienmaster Alienmaster deleted the patch-1 branch March 29, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants