Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit tests for csv2cve.py #1737

Merged
merged 2 commits into from Jul 5, 2022
Merged

test: unit tests for csv2cve.py #1737

merged 2 commits into from Jul 5, 2022

Conversation

yashugarg
Copy link
Contributor

fixes #1736

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #1737 (a44b22c) into main (82ce324) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
+ Coverage   80.20%   80.62%   +0.41%     
==========================================
  Files         300      301       +1     
  Lines        6427     6447      +20     
  Branches     1050     1052       +2     
==========================================
+ Hits         5155     5198      +43     
+ Misses       1054     1033      -21     
+ Partials      218      216       -2     
Flag Coverage Δ
longtests 80.62% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_csv2cve.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 70.86% <0.00%> (+1.96%) ⬆️
cve_bin_tool/cve_scanner.py 86.48% <0.00%> (+2.02%) ⬆️
cve_bin_tool/error_handler.py 93.65% <0.00%> (+4.76%) ⬆️
cve_bin_tool/csv2cve.py 100.00% <0.00%> (+100.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

test/test_csv2cve.py Outdated Show resolved Hide resolved
test/test_csv2cve.py Outdated Show resolved Hide resolved
Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cve scan failure is related to aiohttp and is unrelated, so I'm going to go ahead and merge this.

@terriko terriko merged commit cc58d07 into intel:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: unit tests for csv2cve.py
4 participants