Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(scanner): unittest to cover make_condensed_from_download() #1770

Merged
merged 2 commits into from Jul 12, 2022
Merged

test(scanner): unittest to cover make_condensed_from_download() #1770

merged 2 commits into from Jul 12, 2022

Conversation

yashugarg
Copy link
Contributor

fixes #1769

@terriko
Copy link
Contributor

terriko commented Jul 12, 2022

NVD had a sha mismatch during the longtests, I assume it was a race condition between when we downloaded the signature and the data. I've triggered the longtests to run again.

The race condition is always a possibility (although it's rare that the data gets updated right when you're downloading it, it's never impossible). We might want to consider improving our handling if this comes up more often. It's kind of a pain to test for, though.

terriko
terriko approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we didn't get a codecov comment on this one, but it looks like it's good to go.

@terriko terriko merged commit 1cbf89d into intel:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(scanner): unittest to cover make_condensed_from_download()
2 participants
@yashugarg @terriko