Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor java parser (#1771) #1772

Merged
merged 22 commits into from Jul 13, 2022
Merged

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1771

XDRAGON2002 and others added 21 commits December 29, 2021 17:51
@terriko
Copy link
Contributor

terriko commented Jul 12, 2022

Caused a merge conflict with the java parser refactoring. I've attempted to resolve via the web interface but if black fails you may need to take a look at it @XDRAGON2002 .

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1772 (b41612a) into main (4980849) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
- Coverage   84.10%   84.09%   -0.02%     
==========================================
  Files         309      310       +1     
  Lines        6683     6696      +13     
  Branches     1084     1085       +1     
==========================================
+ Hits         5621     5631      +10     
- Misses        817      820       +3     
  Partials      245      245              
Flag Coverage Δ
longtests 84.09% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/parsers/java.py 73.52% <73.52%> (ø)
cve_bin_tool/parsers/__init__.py 66.66% <100.00%> (ø)
cve_bin_tool/version_scanner.py 87.34% <100.00%> (+4.99%) ⬆️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 70.61% <0.00%> (+0.38%) ⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py 77.55% <0.00%> (+14.28%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I managed to resolve the merge conflict without breaking linting. I'm going to go ahead and merge this now. It may go and cause conflicts in the others.

@terriko terriko merged commit 3ffda11 into intel:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: refactor java parser to the new API format
3 participants