Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add intermediate report in output_html test #1778

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

yashugarg
Copy link
Contributor

fixes #1777

@codecov-commenter
Copy link

Codecov Report

Merging #1778 (bf72011) into main (ff6b6b7) will increase coverage by 0.70%.
The diff coverage is 76.31%.

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
+ Coverage   84.29%   85.00%   +0.70%     
==========================================
  Files         309      310       +1     
  Lines        6724     6740      +16     
  Branches     1091     1092       +1     
==========================================
+ Hits         5668     5729      +61     
+ Misses        803      758      -45     
  Partials      253      253              
Flag Coverage Δ
longtests 85.00% <76.31%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/parsers/java.py 73.52% <73.52%> (ø)
cve_bin_tool/parsers/__init__.py 66.66% <100.00%> (ø)
cve_bin_tool/version_scanner.py 87.34% <100.00%> (+4.99%) ⬆️
test/test_output_engine.py 96.96% <100.00%> (+0.04%) ⬆️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 70.61% <0.00%> (+0.38%) ⬆️
cve_bin_tool/output_engine/print_mode.py 89.65% <0.00%> (+10.34%) ⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py 77.55% <0.00%> (+14.28%) ⬆️
cve_bin_tool/output_engine/html.py 91.66% <0.00%> (+34.09%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yashugarg
Copy link
Contributor Author

@terriko this is ready to merge!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests weren't running on windows but that is likely due to the other issues going on in CI

@terriko terriko merged commit 51ff523 into intel:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add intermediate report to test_html_output
3 participants