New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add go parser (#1881) #1882
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
- Coverage 87.38% 78.42% -8.97%
==========================================
Files 317 319 +2
Lines 7153 7318 +165
Branches 1153 1197 +44
==========================================
- Hits 6251 5739 -512
- Misses 616 1323 +707
+ Partials 286 256 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One nitpicky comment/code documentation suggestion. Tests look good. Could we get some user-facing docs indicating that go support has been added?
BTW, the 3.7 issues did indeed vanish when I re-ran things. If they occur again, we should probably file an issue about them. |
Noting some 3.7 failures here for my own purposes before I re-run the failed jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #1881