Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go parser (#1881) #1882

Merged
merged 27 commits into from Sep 7, 2022
Merged

feat: add go parser (#1881) #1882

merged 27 commits into from Sep 7, 2022

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1881

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #1882 (c5b7ed4) into main (7cb08b4) will decrease coverage by 8.96%.
The diff coverage is 98.07%.

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   87.38%   78.42%   -8.97%     
==========================================
  Files         317      319       +2     
  Lines        7153     7318     +165     
  Branches     1153     1197      +44     
==========================================
- Hits         6251     5739     -512     
- Misses        616     1323     +707     
+ Partials      286      256      -30     
Flag Coverage Δ
longtests 78.42% <98.07%> (?)
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/parsers/__init__.py 95.00% <ø> (ø)
test/test_language_scanner.py 90.00% <92.30%> (+0.34%) ⬆️
cve_bin_tool/parsers/go.py 100.00% <100.00%> (ø)
cve_bin_tool/parsers/parse.py 100.00% <100.00%> (ø)
test/test_requirements.py 0.00% <0.00%> (-89.88%) ⬇️
cve_bin_tool/data_sources/curl_source.py 39.56% <0.00%> (-56.05%) ⬇️
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 29.18% <0.00%> (-50.82%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
test/test_source_nvd.py 60.71% <0.00%> (-39.29%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One nitpicky comment/code documentation suggestion. Tests look good. Could we get some user-facing docs indicating that go support has been added?

cve_bin_tool/parsers/go.py Show resolved Hide resolved
cve_bin_tool/parsers/go.py Show resolved Hide resolved
@terriko
Copy link
Contributor

terriko commented Aug 17, 2022

BTW, the 3.7 issues did indeed vanish when I re-ran things. If they occur again, we should probably file an issue about them.

@terriko
Copy link
Contributor

terriko commented Aug 31, 2022

Noting some 3.7 failures here for my own purposes before I re-run the failed jobs:

=========================== short test summary info ============================
FAILED test/test_extractor.py::TestExtractFileRpm::test_extract_file_rpm - Ru...
FAILED test/test_extractor.py::TestExtractFileRpmWithZstd::test_extract_file_rpm
FAILED test/test_helper_script.py::TestHelperScript::test_scan_files_single
===== 3 failed, 360 passed, 344 skipped, 114 warnings in 101.39s (0:01:41) =====

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@terriko terriko merged commit 91fc3a1 into intel:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add golang language parser
3 participants