Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed MergeReports fuzzer. #1898

Merged
merged 2 commits into from Aug 22, 2022
Merged

Conversation

yashugarg
Copy link
Contributor

@yashugarg yashugarg commented Aug 19, 2022

@terriko, protobuf now uses default values for message fields, if not provided in the fuzzed data.
This should help make the MergeReport fuzzer run!

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1898 (5d6b6b0) into main (3354d63) will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   89.54%   88.33%   -1.22%     
==========================================
  Files         316      316              
  Lines        7224     7224              
  Branches     1176     1176              
==========================================
- Hits         6469     6381      -88     
- Misses        490      586      +96     
+ Partials      265      257       -8     
Flag Coverage Δ
longtests 78.73% <ø> (+0.01%) ⬆️
win-longtests 87.30% <ø> (-1.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
cve_bin_tool/cli.py 77.03% <0.00%> (+0.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad you got something figured out for this problem.

I did run the fuzz_tuples.py over the weekend and got no new results, which was kind of expected but still probably good news! I'll try switching it over to fuzz_intermediate_report_merge.py today if the machine I'm using is still free for a few days.

@terriko terriko merged commit 8bd6ab4 into intel:main Aug 22, 2022
@yashugarg yashugarg deleted the fuzz-json-ireport branch August 28, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants