Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure fuzzer #1906

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

yashugarg
Copy link
Contributor

This PR revamps the current file structure of the fuzz module,
It also includes changes in generated protobuf files allowing all files to run similarly with:
python -m fuzz.fuzz_foo

@codecov-commenter
Copy link

Codecov Report

Merging #1906 (4effa0e) into main (64c1393) will decrease coverage by 2.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
- Coverage   89.64%   87.39%   -2.26%     
==========================================
  Files         316      316              
  Lines        7226     7226              
  Branches     1176     1176              
==========================================
- Hits         6478     6315     -163     
- Misses        484      646     +162     
- Partials      264      265       +1     
Flag Coverage Δ
longtests 78.84% <ø> (+0.01%) ⬆️
win-longtests 86.34% <ø> (-2.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
cve_bin_tool/data_sources/osv_source.py 63.63% <0.00%> (-26.74%) ⬇️
cve_bin_tool/cvedb.py 78.15% <0.00%> (-8.54%) ⬇️
cve_bin_tool/cli.py 77.03% <0.00%> (+0.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice way to restructure stuff. We could still use some more instructions in the fuzz/readme.md file (even if it's just a few lines saying "run python -m fuzz.$option and the list of options is in the directory"), but those can happen in a separate PR.

@terriko terriko merged commit 0facc66 into intel:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants