Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add ntfs-3g checker #2973

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

ffontaine
Copy link
Contributor

No description provided.

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2973 (2c6a236) into main (9bdba0c) will decrease coverage by 2.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   82.67%   80.21%   -2.46%     
==========================================
  Files         674      674              
  Lines       10626    10498     -128     
  Branches     1426     1213     -213     
==========================================
- Hits         8785     8421     -364     
- Misses       1474     1700     +226     
- Partials      367      377      +10     
Flag Coverage Δ
longtests ?
win-longtests 80.21% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.34% <ø> (ø)
cve_bin_tool/checkers/ntfs_3g.py 100.00% <100.00%> (ø)
test/test_data/ntfs_3g.py 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor

terriko commented Jun 1, 2023

I can't see how the test failure here could possibly be related to this code:

=========================== short test summary info ============================
FAILED test/test_cli.py::TestCLI::test_update - aiohttp.client_exceptions.ServerDisconnectedError: Server disconnected
FAILED test/test_cvedb.py::TestCVEDB::test_import_export_json - rich.errors.LiveError: Only one live display may be active at once
======= 2 failed, 22 passed, 2 skipped, 59 warnings in 139.30s (0:02:19) =======

But I'm going to go ahead and re-run for safety (and because I'm going to be busy for a bit so there's time to re-run)

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed upon re-run. I suspect an NVD JSON file was screwed up again and messed with the validation. Anyhow, good to merge now. Thank you!

@terriko terriko merged commit a10ecde into intel:main Jun 6, 2023
21 checks passed
@ffontaine ffontaine deleted the add-ntfs-3g-checker branch June 6, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants