Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve gimp checker #2992

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix: improve gimp checker #2992

merged 2 commits into from
Jun 20, 2023

Conversation

ffontaine
Copy link
Contributor

Improve gimp checker to avoid a false positive with stellarium which embeds images created with GIMP 2.9.9

Improve gimp checker to avoid a false positive with stellarium which
embeds images created with GIMP 2.9.9

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #2992 (0f824dd) into main (dfd0663) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   82.09%   82.10%   +0.01%     
==========================================
  Files         714      714              
  Lines       10983    10983              
  Branches     1476     1476              
==========================================
+ Hits         9016     9018       +2     
+ Misses       1585     1583       -2     
  Partials      382      382              
Flag Coverage Δ
longtests 81.57% <100.00%> (+0.01%) ⬆️
win-longtests 79.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data/gimp.py 100.00% <ø> (ø)
test/test_data/stellarium.py 100.00% <ø> (ø)
cve_bin_tool/checkers/gimp.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor

terriko commented Jun 6, 2023

Not sure what was up with the tests on this run; I'm going to update the branch and re-run them.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, but I'm back from vacation and the tests look good now. Thank you!

@terriko terriko merged commit 6395149 into intel:main Jun 20, 2023
22 checks passed
@ffontaine ffontaine deleted the fix-gimp-checker branch June 21, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants