Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add udisks checker #2999

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

No description provided.

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@terriko
Copy link
Contributor

terriko commented Jun 1, 2023

It doesn't look like the tests ran on this one and I'm not sure why. I'm going to try updating the branch to see if they trigger correctly this time.

@terriko
Copy link
Contributor

terriko commented Jun 1, 2023

Okay, looks like they did actually trigger this time. I'll flag this so I can look at it after they've run.

@codecov-commenter
Copy link

Codecov Report

Merging #2999 (be78c6f) into main (9fc71f1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2999      +/-   ##
==========================================
+ Coverage   82.94%   82.98%   +0.03%     
==========================================
  Files         698      700       +2     
  Lines       10774    10784      +10     
  Branches     1430     1430              
==========================================
+ Hits         8937     8949      +12     
+ Misses       1467     1465       -2     
  Partials      370      370              
Flag Coverage Δ
longtests 81.76% <100.00%> (+0.03%) ⬆️
win-longtests 80.42% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 91.48% <ø> (ø)
cve_bin_tool/checkers/udisks.py 100.00% <100.00%> (ø)
test/test_data/udisks.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything's behaving now. Thanks and sorry for the delay!

@terriko terriko merged commit 6a07a2a into intel:main Jun 6, 2023
22 checks passed
@ffontaine ffontaine deleted the add-udisks-checker branch June 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants