feat(scanner): slight update in version display #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
requested changes
Jun 5, 2023
Replace "v{product_info.version}" by "version {product_info.version}" to
allow the version number to be displayed in the same color (i.e.
"4.19.205" will be displayed in blue and "version" in white instead of
displaying "19.205" in blue and "v4." in white)
Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov Report
@@ Coverage Diff @@
## main #3063 +/- ##
==========================================
- Coverage 82.92% 76.02% -6.90%
==========================================
Files 674 702 +28
Lines 10650 10923 +273
Branches 1429 1476 +47
==========================================
- Hits 8831 8304 -527
- Misses 1457 2292 +835
+ Partials 362 327 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
v{product_info.version}byversion {product_info.version}to allow the version number to be displayed in the same color (i.e.4.19.205will be displayed in blue andversionin white instead of displaying19.205in blue andv4.in white)