Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: root file path of vulnerable component is missing #3088

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix: root file path of vulnerable component is missing #3088

merged 2 commits into from
Jun 20, 2023

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jun 14, 2023

when scanning a file, if a vulnerability is found it should provide the path of the main file, not the extracted temp file.

before:

image

after:

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #3088 (75e8d40) into main (a0b6dfd) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   81.92%   82.18%   +0.25%     
==========================================
  Files         714      714              
  Lines       10983    10984       +1     
  Branches     1476     1477       +1     
==========================================
+ Hits         8998     9027      +29     
+ Misses       1599     1573      -26     
+ Partials      386      384       -2     
Flag Coverage Δ
longtests 76.15% <100.00%> (+<0.01%) ⬆️
win-longtests 79.95% <100.00%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/version_scanner.py 85.31% <100.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid and useful improvement, thanks!

@terriko terriko merged commit 855d3fb into intel:main Jun 20, 2023
22 checks passed
@b31ngd3v b31ngd3v deleted the fix_filepath branch June 20, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants