Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve dnsmasq checker #3121

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Update dnsmasq pattern to catch version on 'exotic' binary

Update dnsmasq pattern to catch version on 'exotic' binary

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #3121 (9b3deba) into main (6d746c7) will decrease coverage by 0.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
- Coverage   82.46%   81.53%   -0.93%     
==========================================
  Files         714      716       +2     
  Lines       10984    11050      +66     
  Branches     1477     1481       +4     
==========================================
- Hits         9058     9010      -48     
- Misses       1543     1645     +102     
- Partials      383      395      +12     
Flag Coverage Δ
longtests 81.00% <ø> (-0.22%) ⬇️
win-longtests 79.14% <ø> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/dnsmasq.py 100.00% <ø> (ø)
test/test_data/dnsmasq.py 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit a0ba8e8 into intel:main Jul 5, 2023
21 checks passed
@ffontaine ffontaine deleted the fix-dnsmasq-checker branch July 5, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants