Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch cves from mirror not working #3122

Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix: fetch cves from mirror not working #3122

merged 2 commits into from
Jul 5, 2023

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jul 2, 2023

fetch from mirror was not working due to recent changes in the db structure (two tables were added cve_metrics and metrics)

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #3122 (72ac3bd) into main (c503c22) will decrease coverage by 1.32%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
- Coverage   83.17%   81.85%   -1.32%     
==========================================
  Files         716      716              
  Lines       11050    11051       +1     
  Branches     1481     1482       +1     
==========================================
- Hits         9191     9046     -145     
- Misses       1466     1621     +155     
+ Partials      393      384       -9     
Flag Coverage Δ
longtests 81.32% <90.90%> (-0.28%) ⬇️
win-longtests 79.46% <90.90%> (-1.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 66.17% <90.00%> (-0.86%) ⬇️
cve_bin_tool/fetch_json_db.py 48.90% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's got to be a more elegant way to handle the year_breakdown stuff, or that we at least need some comments explaining what the expected cases actually mean (I know, there wasn't one before, but part of the fun of code review is that we can use it to encourage refactoring anytime!).

In the interest of getting the mirror fetch working again, I'm going to merge this as is and open a separate issue. suggesting we explain what those cases mean.

@terriko terriko merged commit 279e9fa into intel:main Jul 5, 2023
21 checks passed
@b31ngd3v b31ngd3v deleted the fix_fetch_from_mirror branch July 5, 2023 18:05
@terriko terriko mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants