test: fix tests broken by improved data #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes intel#3157 The improvement to avoid data from multiple sources from clobbering each other caused a few tests to suddenly get new results, so they needed to be updated. This doesn't feel like the most "correct" fix for the package lsit parser's test_valid_ubuntu_list, but that one may need more investigation. This should be ok as a workaround while we sort out the data issue that's causing us to get "unknown" vendors. Signed-off-by: Terri Oda <terri@toybox.ca>
Signed-off-by: Terri Oda <terri@toybox.ca>
Codecov Report
@@ Coverage Diff @@
## main #3160 +/- ##
==========================================
+ Coverage 80.70% 81.43% +0.72%
==========================================
Files 714 716 +2
Lines 10943 11085 +142
Branches 1264 1488 +224
==========================================
+ Hits 8832 9027 +195
+ Misses 1704 1666 -38
+ Partials 407 392 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Terri Oda <terri@toybox.ca>
This was referenced Jul 17, 2023
nedsouza
approved these changes
Jul 17, 2023
|
Thanks @nedsouza ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvement to avoid data from multiple sources from clobbering each other caused a few tests to suddenly get new results, so they needed to be updated.
This doesn't feel like the most "correct" fix for the package lsit parser's test_valid_ubuntu_list, but that one may need more investigation. This should be ok as a workaround while we sort out the data issue that's causing us to get "unknown" vendors.