Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import json flag #3192

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: import json flag #3192

merged 2 commits into from
Jul 31, 2023

Conversation

b31ngd3v
Copy link
Contributor

I was working on a fix for downloading cves from mirror, and found out these while importing json manually.

@b31ngd3v
Copy link
Contributor Author

the year parsing commit will solve the mirror issue (discussed in gitter)

@codecov-commenter
Copy link

Codecov Report

Merging #3192 (c69117b) into main (3fb32c6) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3192      +/-   ##
==========================================
- Coverage   81.11%   81.03%   -0.08%     
==========================================
  Files         716      716              
  Lines       11114    11116       +2     
  Branches     1495     1495              
==========================================
- Hits         9015     9008       -7     
- Misses       1706     1731      +25     
+ Partials      393      377      -16     
Flag Coverage Δ
longtests 81.03% <66.66%> (+5.65%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cve_bin_tool/cli.py 66.09% <ø> (-0.87%) ⬇️
cve_bin_tool/cvedb.py 61.92% <66.66%> (+0.29%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Next time, can you put a summary in the PR itself so I don't have to try to add context from gitter when I do the merge. I think this will be, "Improves the year parsing to avoid an issue where too many files were generated and thus the json import would fail." so it probably doesn't need a whole associated issue, but a sentence or two for the longer commit message would have been helpful. Thanks!

@terriko terriko merged commit ecc4fca into intel:main Jul 31, 2023
21 checks passed
@b31ngd3v b31ngd3v deleted the fix_import_json branch July 31, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants