Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split curl and libcurl checkers #3238

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Fix #3173

@ffontaine ffontaine force-pushed the split-curl-libcurl branch 3 times, most recently from 65e053a to ab1df73 Compare August 11, 2023 09:52
Fix intel#3173

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3238 (ac1fb00) into main (8f10390) will increase coverage by 0.43%.
The diff coverage is 100.00%.

❗ Current head ac1fb00 differs from pull request most recent head d0aa6bd. Consider uploading reports for the commit d0aa6bd to get more accurate results

@@            Coverage Diff             @@
##             main    #3238      +/-   ##
==========================================
+ Coverage   80.99%   81.43%   +0.43%     
==========================================
  Files         722      724       +2     
  Lines       11209    11219      +10     
  Branches     1502     1502              
==========================================
+ Hits         9079     9136      +57     
+ Misses       1726     1688      -38     
+ Partials      404      395       -9     
Flag Coverage Δ
longtests 80.48% <100.00%> (+0.01%) ⬆️
win-longtests 79.11% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cve_bin_tool/checkers/__init__.py 91.48% <ø> (ø)
test/test_cli.py 88.77% <ø> (ø)
test/test_config.py 100.00% <ø> (ø)
test/test_data/curl.py 100.00% <ø> (ø)
cve_bin_tool/checkers/curl.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/libcurl.py 100.00% <100.00%> (ø)
test/test_data/libcurl.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is possible to separate them! Thanks for doing the investigation and getting this sorted out.

@terriko terriko merged commit bac0505 into intel:main Aug 14, 2023
21 checks passed
@ffontaine ffontaine deleted the split-curl-libcurl branch August 14, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: when scan libcurl.dll but in output product part can see curl is there
3 participants