Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gimp tests #3239

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: enable gimp tests #3239

merged 1 commit into from
Aug 14, 2023

Conversation

ffontaine
Copy link
Contributor

gimp tests have been disabled in January 2021 by commit a5d6c25 but they seem to work perfectly fine nowadays (at least on Linux)

gimp tests have been disabled in January 2021 by commit
a5d6c25 but they seem to work perfectly
fine nowadays (at least on Linux)

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #3239 (d467f33) into main (8f10390) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
+ Coverage   80.99%   81.01%   +0.01%     
==========================================
  Files         722      722              
  Lines       11209    11209              
  Branches     1502     1502              
==========================================
+ Hits         9079     9081       +2     
+ Misses       1726     1724       -2     
  Partials      404      404              
Flag Coverage Δ
longtests 80.48% <100.00%> (+0.01%) ⬆️
win-longtests 78.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/test_scanner.py 78.73% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they're behaving in Actions too now. thanks for spotting that these could be re-enabled!

@terriko terriko merged commit b732965 into intel:main Aug 14, 2023
21 checks passed
@ffontaine ffontaine deleted the enable-gimp-tests branch August 14, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants