Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance products with no identified vulnerabilities #3254

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

ffontaine
Copy link
Contributor

Currently, cve-bin-tool will return gnu:zlib in "Products with No Identified Vulnerabilities" if zlib is found but not affected by CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed under above section if a CVE is found with one of the vendor.

Fix #3169

@ffontaine ffontaine force-pushed the enhance-products-no-identified-vulns branch from 0633d82 to 3c49231 Compare August 15, 2023 17:18
@ffontaine ffontaine changed the title feat(scanner): enhance products with no identified vulnerabilities feat: enhance products with no identified vulnerabilities Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #3254 (8c72605) into main (28fe118) will decrease coverage by 5.32%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #3254      +/-   ##
==========================================
- Coverage   80.94%   75.63%   -5.32%     
==========================================
  Files         724      724              
  Lines       11299    11301       +2     
  Branches     1525     1527       +2     
==========================================
- Hits         9146     8547     -599     
- Misses       1740     2420     +680     
+ Partials      413      334      -79     
Flag Coverage Δ
longtests 75.63% <25.00%> (+0.01%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cve_bin_tool/output_engine/__init__.py 60.11% <0.00%> (-2.43%) ⬇️
cve_bin_tool/output_engine/console.py 95.56% <50.00%> (+0.02%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Currently, cve-bin-tool will return gnu:zlib in "Products with No
Identified Vulnerabilities" if zlib is found but not affected by
CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains
two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed
under above section if a CVE is found with one of the vendor.

Fix intel#3169

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine force-pushed the enhance-products-no-identified-vulns branch from 91d66f4 to 60d75ef Compare August 15, 2023 20:44
@terriko
Copy link
Contributor

terriko commented Aug 15, 2023

What a simple and elegant solution to the problem. It looks good at a glance; I'll be back after the tests have run and I'm sure it won't cause any surprise failures.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge time! The failing CVE check is related to the OSV bug we fixed yesterday, so can be ignored.

@terriko terriko merged commit 6b0f36e into intel:main Aug 17, 2023
20 of 21 checks passed
@ffontaine ffontaine deleted the enhance-products-no-identified-vulns branch August 17, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: zlib with known vulnerabilities is showing in "products with no identified vulnerabilities " section
3 participants