fix: rename expat checker #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename expat checker to libexpat to make it more clear that the checker extracts libexpat version Fix intel#1694 Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
rename-expat-checker
branch
from
2be8a42
to
19cd04f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 80.94% 81.17% +0.23%
==========================================
Files 724 724
Lines 11299 11299
Branches 1525 1525
==========================================
+ Hits 9146 9172 +26
+ Misses 1740 1719 -21
+ Partials 413 408 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Aug 16, 2023
|
BTW, the one python test that failed was (of course) the one that's marked as required. Pretty sure it was just a transient network issue and I'm re-running now. the CVE scans are failing for an unrelated issue that's already being worked on. |
|
Time to get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename expat checker to libexpat to make it more clear that the checker extracts libexpat version
Fix #1694