Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cveb.in mirror by default #3265

Merged
merged 6 commits into from
Aug 21, 2023
Merged

feat: use cveb.in mirror by default #3265

merged 6 commits into from
Aug 21, 2023

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Aug 17, 2023

part of #3181

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial run is still using --nvd json in https://github.com/intel/cve-bin-tool/blob/main/.github/workflows/testing.yml

For backwards compatibility, I think we should keep "json" as an option so as not to break people's scripts, but have it now mean the same as json-mirror (e.g. treat it like syntactic sugar). I suspect a lot of people use the --nvd json option right now for update/cache refresh jobs and in CI environments where API/API2 were performing poorly.

@terriko
Copy link
Contributor

terriko commented Aug 17, 2023

Also, I'm excited that this is finally happening! 🎆 🍾

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #3265 (883c2da) into main (3fb32c6) will decrease coverage by 0.17%.
Report is 49 commits behind head on main.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
- Coverage   81.11%   80.95%   -0.17%     
==========================================
  Files         716      724       +8     
  Lines       11114    11314     +200     
  Branches     1495     1532      +37     
==========================================
+ Hits         9015     9159     +144     
- Misses       1706     1743      +37     
- Partials      393      412      +19     
Flag Coverage Δ
longtests 80.43% <70.00%> (+5.04%) ⬆️
win-longtests 78.74% <70.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/test_cli.py 88.77% <ø> (+2.10%) ⬆️
cve_bin_tool/cli.py 66.09% <33.33%> (-0.86%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 55.55% <85.71%> (-0.27%) ⬇️

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor

terriko commented Aug 19, 2023

This looks good to go, but I'm going to wait 'till Monday to merge it so I'm actually at my computer more frequently if we start seeing weirdness.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think we're good to go. I'm going to enable this and we'll see if anything misbehaves over the next few days.

@terriko terriko merged commit 0abbddd into intel:main Aug 21, 2023
21 checks passed
@b31ngd3v b31ngd3v deleted the mirror branch August 22, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants