Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add latest upstream stable version in CPE summary #3267

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Aug 17, 2023

CPE summary table is updated to display the latest upstream stable version (retrieved thanks to release-monitoring project).

This first iteration doesn't use a local cache and so only works in online mode.

@ffontaine ffontaine force-pushed the add-cpe-summary branch 4 times, most recently from 73e157d to bd3bc30 Compare August 17, 2023 21:02
@terriko
Copy link
Contributor

terriko commented Aug 17, 2023

Does https://release-monitoring.org/ have any sort of data license? I can see that the code is GPLv2 but I'm not sure if that's intended to carry over to the data or not.

@ffontaine
Copy link
Contributor Author

Infrastructure code is indeed licensed in GPLv2. However, I don't know what is the "license" of the data stored on release-monitoring.org. If this is an issue, a lawyer will probably have to reach this Fedora project.

@ffontaine ffontaine force-pushed the add-cpe-summary branch 3 times, most recently from fa7950e to ac108c6 Compare August 18, 2023 13:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #3267 (f0e577e) into main (9b23ea9) will increase coverage by 0.38%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   79.67%   80.06%   +0.38%     
==========================================
  Files         758      758              
  Lines       11596    11616      +20     
  Branches     1568     1571       +3     
==========================================
+ Hits         9239     9300      +61     
+ Misses       1932     1897      -35     
+ Partials      425      419       -6     
Flag Coverage Δ
longtests 79.55% <66.66%> (+4.72%) ⬆️
win-longtests 77.89% <66.66%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/cli.py 66.48% <ø> (-0.56%) ⬇️
cve_bin_tool/output_engine/__init__.py 62.74% <100.00%> (+0.38%) ⬆️
test/test_output_engine.py 96.82% <ø> (ø)
cve_bin_tool/output_engine/console.py 93.26% <60.00%> (-0.92%) ⬇️
cve_bin_tool/output_engine/util.py 84.69% <66.66%> (-3.26%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ffontaine
Copy link
Contributor Author

ffontaine commented Aug 18, 2023

I can split this PR in two if needed: a first one to add CPE summary with the count of CVEs for each package and an other one that adds "latest upstream version"

@terriko
Copy link
Contributor

terriko commented Aug 23, 2023

I happened to chat with someone who is not a lawyer but works in similar compliance problems, and he suspects that the data we're using is too simple and machine-translatable to carry a copyright, which is maybe why it doesn't have one. But it doesn't absolve me of the responsibility of checking with our own compliance team and seeing if they want to reach out to fedora to clarify, so I'm going to flag this like a requirements change and plan to open a ticket with the right people to ask later today.

@terriko terriko added the dependencies Pull requests that update a dependency file label Aug 23, 2023
@ffontaine
Copy link
Contributor Author

Understood, then I opened #3277 to hopefully merge the addition of CPE summary table (but without the information on the latest stable version retrieved from release-monitoring)

CPE summary table is updated to display the latest upstream stable
version (retrieved thanks to release-monitoring project).

This first iteration doesn't use a local cache and so only works in
online mode.

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine changed the title feat: add CPE summary feat: add latest upstream stable version in CPE summary Aug 25, 2023
@terriko
Copy link
Contributor

terriko commented Sep 21, 2023

Quick update on this: licensing didn't say no but they did ask me to update a bunch of paperwork, then it got put on hold while I was out sick. But it's in process, I just need to prompt them to keep it moving.

@terriko
Copy link
Contributor

terriko commented Oct 16, 2023

I got a random "ok" with no explanation on my new licensing paperwork, so I think we're good to merge this. I'm going to update the branch to make sure nothing has gone awry before I do so, though.

@terriko terriko added awaiting maintainer Need a maintainer to respond / help out dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Oct 16, 2023
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are mostly behaving (the fails were in the may-fail tests and a whitespace issue in gitlint that I'll fix during merge). Thank you again for this one and sorry it took so long to sort out whether I could merge it! I think a number of people will find this version info useful.

@terriko terriko merged commit fb39948 into intel:main Oct 17, 2023
19 of 21 checks passed
@ffontaine ffontaine deleted the add-cpe-summary branch October 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants