Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional openssh CPE ID #3291

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

CVE-2023-25136 is registered under openssh:openssh CPE ID

CVE-2023-25136 is registered under openssh:openssh CPE ID

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #3291 (d93e5f4) into main (122f306) will increase coverage by 0.29%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
+ Coverage   80.62%   80.92%   +0.29%     
==========================================
  Files         724      724              
  Lines       11375    11400      +25     
  Branches     1551     1559       +8     
==========================================
+ Hits         9171     9225      +54     
+ Misses       1778     1750      -28     
+ Partials      426      425       -1     
Flag Coverage Δ
longtests 80.40% <100.00%> (+4.75%) ⬆️
win-longtests 78.72% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cve_bin_tool/checkers/openssh.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new cpeid makes sense, but every time we get a switch like this I wonder if it's a permanent change or a one-off because someone filed incorrectly. Only time will tell, I guess?

Thanks for spotting it. I wonder if we need some automated stuff that warns us of potential changes like this for the binary checkers? The non-binary ones kind of glom everything with the same name but that has other problems...

@terriko terriko merged commit a9d22bf into intel:main Sep 11, 2023
21 checks passed
@ffontaine ffontaine deleted the fix-openssh-checker branch September 11, 2023 19:34
@ffontaine
Copy link
Contributor Author

I don't really understand why NVD has some many different CPE IDs for the same product. They don't even seem to check if there is one in the database before accepting a new one ... Perhaps something could be added to detect a new CPE ID for a given product or to detect deprecation of CPE IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants