fix: fix products with no identified vulnerabilities #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Products with no identified vulnerabilities are broken since commit 6b0f36e because products_with_cves will always contain a dictionnary of all products. So replace the broken lamba function with a more clear way of computing products with CVEs (i.e. len(cve_data["cves"])) Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov Report
@@ Coverage Diff @@
## main #3300 +/- ##
==========================================
- Coverage 81.20% 80.75% -0.45%
==========================================
Files 724 724
Lines 11400 11403 +3
Branches 1559 1560 +1
==========================================
- Hits 9257 9209 -48
- Misses 1698 1764 +66
+ Partials 445 430 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ffontaine
deleted the
fix-products-with-no-identified-vulnerabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Products with no identified vulnerabilities are broken since commit 6b0f36e because
products_with_cveswill always contain a dictionnary of all products. So replace the broken lamba function with a more clear way of computing products with CVEs (i.e.len(cve_data["cves"]))