Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove dependabot ignores #3348

Merged
merged 1 commit into from
Sep 21, 2023
Merged

ci: Remove dependabot ignores #3348

merged 1 commit into from
Sep 21, 2023

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Sep 18, 2023

These were a nice idea, but the auto-ignores are causing a problem with an internal automated script so they'll need to be disabled and I'll need to go back to manually discarding dependabot results in test/language_data

These were a nice idea, but are causing a problem with an internal automated script so they'll need to be disabled and I'll need to go back to manually discarding dependabot results in `test/language_data`
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #3348 (c9522e7) into main (b4905ef) will increase coverage by 0.79%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   80.54%   81.34%   +0.79%     
==========================================
  Files         732      732              
  Lines       11443    11443              
  Branches     1560     1560              
==========================================
+ Hits         9217     9308      +91     
+ Misses       1790     1689     -101     
- Partials      436      446      +10     
Flag Coverage Δ
longtests 75.63% <ø> (ø)
win-longtests 79.27% <ø> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@novafacing novafacing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to remove, commented or deleted up to preference.

ignore:
- dependency-name: "*"

# These are commented out because they caused problems with other automated checks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might just be my preference, should these lines all just be deleted? They can always be restored from git history, just a little clutter avoidance :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this commented out rather than removing it so I don't forget why this was a bad idea and try it again in 6 months, or have someone else propose it when I gripe about the process. I guess that would be just as well handled by a single comment line, but I don't mind a bit of clutter in this case.

@terriko terriko merged commit 826c9e3 into main Sep 21, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants