test: improve flaky java language scanner test #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Related: intel#3360 * Fixes: intel#3361 For some reason we're getting non-deterministic behaviour around commons-io (with a dash) vs commons_io (with an underscore) during detection. Since the test doesn't really need to detect that partcular library, we're leaving it out for now while the issue is investigated further. Signed-off-by: Terri Oda <terri.oda@intel.com>
Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Oct 2, 2023
This is just in case intel#3362 doesn't work as expected. Signed-off-by: Terri Oda <terri.oda@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #3362 +/- ##
==========================================
- Coverage 81.07% 78.92% -2.15%
==========================================
Files 750 748 -2
Lines 11534 11392 -142
Branches 1560 1330 -230
==========================================
- Hits 9351 8991 -360
- Misses 1734 1965 +231
+ Partials 449 436 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nedsouza
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we're getting non-deterministic behaviour around commons-io (with a dash) vs commons_io (with an underscore) during detection. Since the test doesn't really need to detect that partcular library, we're leaving it out for now while the issue is investigated further.