Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing docstrings to log.py #3383 #3388

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

NabhiA
Copy link
Contributor

@NabhiA NabhiA commented Oct 4, 2023

fixes #3383
docstrings added to the file as mentioned in the issue

@NabhiA NabhiA changed the title Fix: add missing docstrings to log.py #3383 docs: add missing docstrings to log.py #3383 Oct 4, 2023
@NabhiA
Copy link
Contributor Author

NabhiA commented Oct 4, 2023

please let me know if something needs to be changed

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #3388 (83e17e3) into main (2847879) will increase coverage by 5.21%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3388      +/-   ##
==========================================
+ Coverage   75.83%   81.05%   +5.21%     
==========================================
  Files         750      750              
  Lines       11534    11534              
  Branches     1560     1560              
==========================================
+ Hits         8747     9349     +602     
+ Misses       2435     1759     -676     
- Partials      352      426      +74     
Flag Coverage Δ
longtests 75.81% <ø> (-0.02%) ⬇️
win-longtests 79.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/log.py 76.92% <ø> (ø)

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ci: add conditional execution for SBOM workflow on the main repositor…
@NabhiA
Copy link
Contributor Author

NabhiA commented Oct 5, 2023

I am unable to understand the error thrown in this pr. It will be really helpful if I can get some assistance @terriko

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the linters are failing. You can read about our linters, what they're for and how to run them here:
https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters

At a glance, the issue is likely some whitespace blank lines that black and isort want added/removed.

If you don't already have them installed, run
pip install black isort
to install them.

Then you'll need to run each of those tools on the file, and they should automatically reformat to their standards:

isort log.py
black log.py

Then add/commit the updated file to your PR and you should pass the tests on the next run!

@NabhiA
Copy link
Contributor Author

NabhiA commented Oct 11, 2023

I have ran both the commands on the file. Please check if this works or if its okay I can raise a new PR for it

@NabhiA NabhiA requested a review from terriko October 12, 2023 04:26
@NabhiA
Copy link
Contributor Author

NabhiA commented Oct 12, 2023

I have addressed all the issues. Please check if it works well

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you! Congratulations on your first merged commit with us and happy hacktoberfest!

@terriko terriko merged commit 4b72a4f into intel:main Oct 12, 2023
21 checks passed
@NabhiA
Copy link
Contributor Author

NabhiA commented Oct 13, 2023

Thank you for guiding me through! Please let me know if there are more such good first issues open which I can address, I will be glad to contribute again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add missing docstrings to log.py
3 participants