Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing docstrings to cvedb.py #3392

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Conversation

reginareynolds
Copy link
Contributor

Closes #3379
I've added all of the docstrings that were missing in cvedb.py. I also fixed a couple typos in existing docstrings and comments.

@terriko
Copy link
Contributor

terriko commented Oct 5, 2023

I've approved the tests to run and I'll be back to review this sometime after they're done!

@codecov-commenter
Copy link

Codecov Report

Merging #3392 (249f440) into main (2847879) will increase coverage by 3.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
+ Coverage   75.83%   79.01%   +3.17%     
==========================================
  Files         750      748       -2     
  Lines       11534    11392     -142     
  Branches     1560     1330     -230     
==========================================
+ Hits         8747     9001     +254     
+ Misses       2435     1958     -477     
- Partials      352      433      +81     
Flag Coverage Δ
longtests ?
win-longtests 79.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/cvedb.py 62.41% <ø> (+33.05%) ⬆️

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thank you especially for the typo spotting and fixing! Congratulations on your first merged pull request with us and happy hacktoberfest!

@terriko terriko merged commit 1e6f492 into intel:main Oct 11, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add missing docstrings to cvedb.py
3 participants