-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fuzz testing PythonRequirementsParser #3397
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 75.83% 79.98% +4.14%
==========================================
Files 750 758 +8
Lines 11534 11596 +62
Branches 1560 1568 +8
==========================================
+ Hits 8747 9275 +528
+ Misses 2435 1902 -533
- Partials 352 419 +67
Flags with carried forward coverage won't be shown. Click here to find out more. see 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I've got a couple of nitpicks about the SPDX licensing lines: updating the year in the .proto file and I've suggested a pair of SPDX license strings for the non-autogenerated file. I just put in our default Intel one, but if you want to use your own name in place of Intel that works too -- the important part is that the license must be compatible.
Other than that, I think this looks ready to merge, and hopefully I'll get a chance to run it for a longer go in preparation for our next release!
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Thank you for the review, i've commited the suggestion into new commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! I'm marking it as approved now but the tests need to re-run before it'll merge.
Getting this merged today! thank you again, congratulations on your first merged commit with us, and happy hacktoberfest! |
fixes #3330
Added fuzz testing for PythonRequirementsParser. Proto is based on
requirements.txt
specification. Every point exceptenvironment markers
is already added to protoI have tested on my local machine, here's the output: