Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve tcpdump checker #3414

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Improve tcp pattern to catch version in 'exotic' and latest tcpdump binaries

Improve tcp pattern to catch version in 'exotic' and latest tcpdump
binaries

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3414 (4cedd15) into main (b543692) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
- Coverage   79.88%   79.57%   -0.32%     
==========================================
  Files         758      758              
  Lines       11596    11596              
  Branches     1568     1568              
==========================================
- Hits         9264     9228      -36     
- Misses       1912     1952      +40     
+ Partials      420      416       -4     
Flag Coverage Δ
longtests 79.57% <ø> (+0.19%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/checkers/tcpdump.py 100.00% <ø> (ø)
test/test_data/tcpdump.py 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit 56fc482 into intel:main Oct 12, 2023
21 checks passed
@ffontaine ffontaine deleted the fix-tcpdump-checker branch October 13, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants