Testing CVE-Bin-Tool with Python 3.12 on Github

[Ferdinand-Ogama]

No description provided.

[terriko]

Glad you made it this far! I've approved the tests to run and we'll see if 3.12 causes any surprise problems. I'll be back to look at this more closely after the tests run (but it'll probably be tomorrow given what else I have on my plate today)

[codecov-commenter]

Codecov Report

Merging #3445 (07e39c9) into main (fb39948) will decrease coverage by 2.55%.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
- Coverage   80.49%   77.95%   -2.55%     
==========================================
  Files         758      756       -2     
  Lines       11616    11474     -142     
  Branches     1571     1341     -230     
==========================================
- Hits         9350     8944     -406     
- Misses       1842     2107     +265     
+ Partials      424      423       -1     

Flag	Coverage Δ
longtests	?
win-longtests	77.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[terriko]

We learned a thing! Python 3.12 doesn't work right now because we can't install aiohttp. I think that's likely way beyond what you'd want to debug (and it might not be fixable) so let's shift from enabling python 3.12 to putting a note explaining what's not working there so people trying to use python 3.12 know what to expect. I've made a suggestion you can accept (and then the tests will re-run and hopefully we'll be set to merge this!) or if you want you can write your own explanation.

Basically instead of enabling 3.12 we're noting why it didn't work as a comment so you can still get a hacktoberfest commit, if you want!

[Ferdinand-Ogama]

I can't explain in a better way than you just did, and I still want that Hacktoberfet commit :)

[Ferdinand-Ogama]

You've also indicated, "I've made a suggestion you can accept (and then the tests will re-run and hopefully we'll be set to merge this!)," how do I go about this?

[terriko]

You've also indicated, "I've made a suggestion you can accept (and then the tests will re-run and hopefully we'll be set to merge this!)," how do I go about this?

There should be a button that looks like "commit suggestion" button somewhere under where I made the suggestion (the green/red diff thing that shows up as a comment from me). For me it shows up both on this page with the comments and the "files changed" tab.

[Ferdinand-Ogama]

Done.

[terriko]

Marking this as approved now, but I'll need to come back to merge it after the tests finish. Thanks for trying this one out and happy hacktoberfest!

[terriko]

Merging now. Thanks again for experimenting on this!