Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update SBOM for Python 3.11 #3446

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore: update SBOM for Python 3.11 #3446

merged 1 commit into from
Oct 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@terriko
Copy link
Contributor

terriko commented Oct 23, 2023

Moment of truth for our CI changes. Closing and re-opening for tests.

@terriko terriko closed this Oct 23, 2023
@terriko terriko reopened this Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #3446 (903af4a) into main (30b85ba) will increase coverage by 5.52%.
Report is 11 commits behind head on main.
The diff coverage is n/a.

❗ Current head 903af4a differs from pull request most recent head cb26062. Consider uploading reports for the commit cb26062 to get more accurate results

@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
+ Coverage   74.82%   80.34%   +5.52%     
==========================================
  Files         758      758              
  Lines       11616    11811     +195     
  Branches     1571     1630      +59     
==========================================
+ Hits         8692     9490     +798     
+ Misses       2581     1880     -701     
- Partials      343      441      +98     
Flag Coverage Δ
longtests 75.10% <ø> (+0.28%) ⬆️
win-longtests 78.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor

terriko commented Oct 25, 2023

omg, this looks like it's working. I'm going to tweak this a bit to handle the longtests as well (and probably disable a few more things) and maybe pull the ci changes into a separate PR and get a colleague to do code review.

terriko added a commit to terriko/cve-bin-tool that referenced this pull request Oct 25, 2023
The earlier PR skipping tests caused issues with our branch protection rules
and had to be disabled because it blocked merging of pull requests (if the
tests were skipped, the PR could never be merged).  This allows part of the job
to run (so it'll pass branch protection checks) while skipping the install and
running of tests on sbom jobs provided by our automated job.

Note that this is the same code as I had in intel#3446 but I'm separating it out so
it gets a proper code review from someone who is not me.

Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko added a commit that referenced this pull request Oct 30, 2023
The earlier PR skipping tests caused issues with our branch protection rules
and had to be disabled because it blocked merging of pull requests (if the
tests were skipped, the PR could never be merged).  This allows part of the job
to run (so it'll pass branch protection checks) while skipping the install and
running of tests on sbom jobs provided by our automated job.

Note that this is the same code as I had in #3446 but I'm separating it out so
it gets a proper code review from someone who is not me.

Signed-off-by: Terri Oda <terri.oda@intel.com>
@terriko terriko closed this Oct 30, 2023
@terriko terriko reopened this Oct 30, 2023
@terriko terriko merged commit 9459c05 into main Oct 30, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants