Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update SBOM for Python 3.8 #3449

Merged
merged 7 commits into from
Oct 25, 2023
Merged

chore: update SBOM for Python 3.8 #3449

merged 7 commits into from
Oct 25, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@terriko
Copy link
Contributor

terriko commented Oct 23, 2023

Moment of truth for our CI changes. Closing and re-opening for tests.

@terriko terriko closed this Oct 23, 2023
@terriko terriko reopened this Oct 23, 2023
@terriko
Copy link
Contributor

terriko commented Oct 24, 2023

Darn, so skipping things in this way results in an un-mergeable pull request. Not the desired effect at all; I'll have to revert the other PR.

Having the if statement at the top of the job caused a situation where the job
didn't complete and the sboms could never be merged due to branch protection
rules.  This attempts to just skip the tests and see if that addresses the
problem in a different way.

Signed-off-by: Terri Oda <terri.oda@intel.com>
@terriko
Copy link
Contributor

terriko commented Oct 24, 2023

I'm currently playing around with some different ways to skip tests in this branch to see if we can resolve this without fully re-enabling the tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #3449 (b08bbad) into main (30b85ba) will increase coverage by 5.12%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   74.82%   79.95%   +5.12%     
==========================================
  Files         758      758              
  Lines       11616    11796     +180     
  Branches     1571     1624      +53     
==========================================
+ Hits         8692     9431     +739     
+ Misses       2581     1942     -639     
- Partials      343      423      +80     
Flag Coverage Δ
longtests 75.09% <ø> (+0.26%) ⬆️
win-longtests 77.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor

terriko commented Oct 25, 2023

Merging this now. This will re-enable the tests marked as required, which isn't quite what I want but it will allow me to merge the SBOMs for this week while we continue to refine the CI to avoid unnecessary testing.

@terriko terriko merged commit cce435d into main Oct 25, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants