Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve gdb checker #3520

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: improve gdb checker #3520

merged 1 commit into from
Nov 27, 2023

Conversation

ffontaine
Copy link
Contributor

Improve gdb pattern to handle openwrt gdb binaries

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error on windows does look related:

 =========================== short test summary info ===========================
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://rpmfind.net/linux/opensuse/ports/aarch64/tumbleweed/repo/oss/aarch64/-perl-5.36.0-3.5.aarch64.rpm-perl-5.36.0-other_products773] - AssertionError: gdb found in perl-5.36.0-3.5.aarch64.rpm. If that's expected, make sure to add gdb to the expected list of other_products.
assert 'gdb' not in {'gdb', 'perl'}

I'm not sure what weird strings there are in perl and why it's only triggering on the windows scans. Did the defaults for how windows checks out files change or something that might be causing aberrant results? We saw some odd behaviour on windows in some of the hacktoberfest checkers too.

Improve gdb pattern to handle openwrt gdb binaries

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine
Copy link
Contributor Author

I fixed the pattern, issue was also raised on Linux.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is behaving now. thank you!

@terriko terriko merged commit 7314e5b into intel:main Nov 27, 2023
21 checks passed
@ffontaine ffontaine deleted the fix-gdb-checker branch November 27, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants