-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added PURL generation to rust parser #3859
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3859 +/- ##
==========================================
+ Coverage 75.41% 80.68% +5.26%
==========================================
Files 808 820 +12
Lines 11983 12419 +436
Branches 1598 1683 +85
==========================================
+ Hits 9037 10020 +983
+ Misses 2593 1969 -624
- Partials 353 430 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This one's based on purl-go branch, I'll rebase when the other one is merged. |
My code for the |
* Related: intel#3771 Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Re-running the failing windows test. I'm not actually sure how this could possibly have caused the failure it's having. |
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Seems it was due to bad cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been a while but I think we're good to merge. Thanks for your patience!
Related: #3771.