Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added PURL generation to rust parser #3859

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

inosmeet
Copy link
Contributor

Related: #3771.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 80.68%. Comparing base (d6cbe40) to head (04ac9db).
Report is 114 commits behind head on main.

Files Patch % Lines
cve_bin_tool/parsers/rust.py 29.41% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3859      +/-   ##
==========================================
+ Coverage   75.41%   80.68%   +5.26%     
==========================================
  Files         808      820      +12     
  Lines       11983    12419     +436     
  Branches     1598     1683      +85     
==========================================
+ Hits         9037    10020     +983     
+ Misses       2593     1969     -624     
- Partials      353      430      +77     
Flag Coverage Δ
longtests 75.67% <29.41%> (+0.25%) ⬆️
win-longtests 78.73% <29.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inosmeet
Copy link
Contributor Author

This one's based on purl-go branch, I'll rebase when the other one is merged.

@joydeep049
Copy link
Contributor

joydeep049 commented Feb 27, 2024

My code for the java and python PURL generation is ready.
I'll give a PR after this is merged.
Next I think I'll be working on ruby, swift and perl @terriko

* Related: intel#3771

Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet inosmeet marked this pull request as ready for review March 14, 2024 14:23
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@terriko
Copy link
Contributor

terriko commented Mar 21, 2024

Re-running the failing windows test. I'm not actually sure how this could possibly have caused the failure it's having.

Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
Copy link
Contributor Author

Seems it was due to bad cache.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been a while but I think we're good to merge. Thanks for your patience!

@terriko terriko merged commit dc95e61 into intel:main Apr 3, 2024
23 checks passed
@inosmeet inosmeet deleted the purl-rust branch April 11, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants