Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed language parsers and query #4188

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

inosmeet
Copy link
Contributor

Changed all the language parsers according to the purl2cpe database and made the database query universal for all parsers.

changed all the language parsers according to the purl2cpe database
and made the database query universal for all parsers

Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
removed 'slf4j-simple' and 'slf4j-api' products from fail_pom.xml
file as they can be found now with purl2cpe

Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally removed a copyright line, but otherwise I think this looks good. I wonder if we should refactor so you don't have to have the same if not... find_vendor code everywhere, but that's probably not the best use of your time.

cve_bin_tool/parsers/ruby.py Outdated Show resolved Hide resolved
@terriko
Copy link
Contributor

terriko commented Jun 18, 2024

I've applied the copyright line fix. Assuming the linters run this should be ready to merge. I'll be back to check on it later.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're good to merge!

@terriko terriko merged commit c794765 into intel:main Jun 18, 2024
22 checks passed
@inosmeet inosmeet deleted the refactor branch June 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants